Skip to content

NodeOutOfServiceVolumeDetach feature update to beta #37374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

NodeOutOfServiceVolumeDetach feature update to beta #37374

merged 1 commit into from
Nov 17, 2022
+3 −2

Conversation

@YuikoTakada
Copy link
Contributor

@YuikoTakada YuikoTakada commented Oct 19, 2022

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from onlydole October 19, 2022 02:56
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2022
@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4a8014e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6369a71307f7250009485c2a
😎 Deploy Preview https://deploy-preview-37374--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@YuikoTakada YuikoTakada mentioned this pull request Oct 24, 2022
Closed
@xing-yang
Copy link
Contributor

xing-yang commented Nov 1, 2022

@YuikoTakada There are other places in the doc where we need to update the feature gate. See this earlier doc PR: #32406

@YuikoTakada
Copy link
Contributor Author

YuikoTakada commented Nov 2, 2022

@xing-yang This file content/en/docs/reference/command-line-tools-reference/feature-gates.md also needs to be updated because the doc content/en/docs/reference/labels-annotations-taints/_index.md which has been updated by #32406 is about taint and this doesn't describe about that which k8s version NodeOutOfServiceVolumeDetach feature gate is enabled.

@YuikoTakada YuikoTakada force-pushed the update_NodeOutOfServiceVolumeDetach_beta branch from 97b6f65 to 843ca04 Compare November 2, 2022 05:23
@xing-yang
Copy link
Contributor

xing-yang commented Nov 4, 2022 •
edited
Loading

@YuikoTakada I assume you'll be updating the feature state status on this page in this PR as well?
https://kubernetes.io/docs/concepts/architecture/nodes/#non-graceful-node-shutdown

@YuikoTakada YuikoTakada force-pushed the update_NodeOutOfServiceVolumeDetach_beta branch from 843ca04 to 4a8014e Compare November 8, 2022 00:47
@YuikoTakada
Copy link
Contributor Author

YuikoTakada commented Nov 8, 2022

@xing-yang Sorry, I misunderstood what you said. I updated content/en/docs/concepts/architecture/nodes.md also, PTAL.

@xing-yang
Copy link
Contributor

xing-yang commented Nov 9, 2022

/lgtm

@YuikoTakada Can you remove WIP?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@YuikoTakada YuikoTakada changed the title [WIP]NodeOutOfServiceVolumeDetach feature update to beta NodeOutOfServiceVolumeDetach feature update to beta Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2022
@YuikoTakada
Copy link
Contributor Author

YuikoTakada commented Nov 9, 2022

/lgtm

@YuikoTakada Can you remove WIP?

done. Thanks.

@tengqm
Copy link
Contributor

tengqm commented Nov 9, 2022

/hold
This one should target dev-1.26 branch rather than main.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Nov 9, 2022

/lgtm cancel
Please address this comment: #37374 (comment)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@YuikoTakada YuikoTakada changed the base branch from main to dev-1.26 November 10, 2022 06:32
@YuikoTakada
Copy link
Contributor Author

YuikoTakada commented Nov 10, 2022

@tengqm @xing-yang Done, thanks.

@tengqm
Copy link
Contributor

tengqm commented Nov 10, 2022

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 10, 2022

LGTM label has been added.

Git tree hash: 93379a54f8f08aac38b1dd6c92071d4c416f8a6f

@xing-yang
Copy link
Contributor

xing-yang commented Nov 14, 2022

/lgtm

@sftim
Copy link
Contributor

sftim commented Nov 17, 2022

Thanks

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2a07f79 into kubernetes:dev-1.26 Nov 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@onlydole onlydole Awaiting requested review from onlydole

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

1.26

Development

Successfully merging this pull request may close these issues.

5 participants

@YuikoTakada @xing-yang @tengqm @k8s-ci-robot @sftim