pod-overhead: updates for beta #19059

egernst · 2020-02-10T23:00:16Z

Pull Request for updating PodOverhead documentation for 1.18, beta.

k8sio-netlify-preview-bot · 2020-02-10T23:00:20Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 9f6ed1c

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5e6906a236db4c0008104ee5

makoscafee · 2020-02-19T20:25:55Z

/milestone 1.18

irvifa · 2020-03-03T20:49:54Z

@egernst Hi 👋 please don't forget to add any technical reviewer for this docs if it's ready to be reviewed. Thanks!

egernst · 2020-03-03T20:53:48Z

@irvifa - can you help identify appropriate tech reviewers (are you one?)?

I have a local draft I'm cleaning up and will submit soon.

irvifa · 2020-03-03T20:58:38Z

Hi @egernst I'm pinging Tim and Vineeth. Nope I'm not a tech reviewer for this, you also can probably assign one of your SIG member to review your docs as well..

Hi @sftim by the way do you aware on whom should I contact for the tech reviewer cc @VineethReddy02 as well..

sftim · 2020-03-04T07:43:31Z

SIG Node is the owning SIG here, so I'd ping @kubernetes/sig-node-pr-reviews

sftim · 2020-03-04T07:44:55Z

@egernst you should add a /hold if the feature graduation is not confirmed, otherwise you don't need a hold
and then you should retitle to remove the WIP status (highlighting that this is ready for approval).

irvifa · 2020-03-06T05:28:35Z

@egernst since we're close to the deadlines do you already confirm the graduation and whether this PR is ready to be reviewed? Thanks!

egernst · 2020-03-07T01:05:48Z

It will be graduating, but this PR isn't ready yet. Hoping to do finalize PR this weekend.

VineethReddy02 · 2020-03-07T13:07:53Z

👋 Please rebase this PR on dev-1.18 in order to avoid merge conflicts.

Feel free to /hold cancel after you've rebased.

/hold

Signed-off-by: Eric Ernst <[email protected]>

sftim

A bit more feedback.

I don't really understand how the reader works out what do to when they see:

root@kind-worker2:~# cat /sys/fs/cgroup/memory/kubepods/podd7f4b509-cf94-4951-9417-d1087c92a5b2/memory.limit_in_bytes

content/en/docs/concepts/configuration/pod-overhead.md

sftim · 2020-03-09T17:32:17Z

content/en/docs/concepts/configuration/pod-overhead.md

+
+Verify the pod level cgroup:
+```bash
+root@kind-worker2:~# cat /sys/fs/cgroup/memory/kubepods/podd7f4b509-cf94-4951-9417-d1087c92a5b2/memory.limit_in_bytes


This isn't valid bash code.

You could revise this along the lines of:

Suggested change

root@kind-worker2:~# cat /sys/fs/cgroup/memory/kubepods/podd7f4b509-cf94-4951-9417-d1087c92a5b2/memory.limit_in_bytes

# Run this inside the node where the Pod is scheduled

#

# Also, change the name of the cgroup to match the cgroup that your container runtime allocated

cat /sys/fs/cgroup/memory/kubepods/podd7f4b509-cf94-4951-9417-d1087c92a5b2/memory.limit_in_bytes

something like that?

content/en/docs/concepts/configuration/pod-overhead.md

content/en/docs/concepts/containers/runtime-class.md

egernst · 2020-03-09T20:24:56Z

Thanks @sftim. I reworded the "on the node" portion - let me know if this makes more sense.

sftim

Nice, thank you @egernst
/lgtm

tallclair

Thanks! Just a few minor suggestions.

tallclair · 2020-03-10T18:21:49Z

content/en/docs/concepts/configuration/pod-overhead.md

+After the RuntimeClass admission controller, you can check the updated PodSpec:
+
+```bash
+kubectl get pod test-pod -o jsonpath='{.spec.overhead}'


Is pod overhead included in the output of kubectl describe? If so, that might be a more user-friendly way of checking

It is not part of kubectl describe.

content/en/docs/concepts/configuration/pod-overhead.md

egernst · 2020-03-10T20:49:22Z

Great suggestions; thanks @tallclair

Updated ya'll - PTAL.

sftim

Looks good to me; one nit.

content/en/docs/concepts/configuration/pod-overhead.md

Signed-off-by: Eric Ernst <[email protected]>

egernst · 2020-03-11T15:42:32Z

Updated @sftim PTAL

VineethReddy02 · 2020-03-12T20:00:24Z

Hi @egernst
We are very close to the docs final deadline i.e All 1.18 enhancements docs should be in ready to merge state by Monday 16th March. Please make sure to complete all the docs reviews before the deadline.

Thanks!

egernst · 2020-03-13T04:22:20Z

@tallclair @sftim -- thanks for the reviews and great feedback. Can you help take one more pass?

tallclair

/lgtm

Thanks!

derekwaynecarr · 2020-03-13T18:59:21Z

/approve

irvifa · 2020-03-14T14:46:51Z

/assign @sftim

irvifa · 2020-03-14T14:47:02Z

/assign @VineethReddy02

VineethReddy02 · 2020-03-14T15:08:51Z

/lgtm
/approve

k8s-ci-robot · 2020-03-14T15:09:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, VineethReddy02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [VineethReddy02]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 10, 2020

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2020

egernst mentioned this pull request Feb 10, 2020

Pod Overhead: account resources tied to the pod sandbox, but not specific containers kubernetes/enhancements#688

Closed

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 10, 2020

k8s-ci-robot requested review from dchen1107 and tallclair February 10, 2020 23:01

egernst mentioned this pull request Feb 19, 2020

Tracking PodOverhead graduation to beta for 1.18 release kubernetes/kubernetes#88339

Closed

6 tasks

k8s-ci-robot added this to the 1.18 milestone Feb 19, 2020

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 4, 2020

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2020

pod-overhead: updates for beta

93a5942

Signed-off-by: Eric Ernst <[email protected]>

egernst force-pushed the pod-overhead-docs branch 4 times, most recently from 7ab7b1d to 710355e Compare March 8, 2020 05:13

egernst changed the title ~~WIP: pod-overhead: updates for beta~~ pod-overhead: updates for beta Mar 8, 2020

sftim reviewed Mar 9, 2020

View reviewed changes

egernst force-pushed the pod-overhead-docs branch 2 times, most recently from e867203 to af088e0 Compare March 9, 2020 20:23

sftim reviewed Mar 10, 2020

View reviewed changes

k8s-ci-robot assigned sftim Mar 10, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020

sftim mentioned this pull request Mar 10, 2020

Tidy RuntimeClass page for v1.18 #19578

Merged

tallclair reviewed Mar 10, 2020

View reviewed changes

egernst force-pushed the pod-overhead-docs branch from af088e0 to b08c3ab Compare March 10, 2020 19:53

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020

sftim reviewed Mar 10, 2020

View reviewed changes

content/en/docs/concepts/configuration/pod-overhead.md Outdated Show resolved Hide resolved

egernst force-pushed the pod-overhead-docs branch from b08c3ab to d357eca Compare March 11, 2020 15:40

pod-overhead: update documentation for beta

9f6ed1c

Signed-off-by: Eric Ernst <[email protected]>

egernst force-pushed the pod-overhead-docs branch from d357eca to 9f6ed1c Compare March 11, 2020 15:41

tallclair reviewed Mar 13, 2020

View reviewed changes

k8s-ci-robot assigned tallclair Mar 13, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2020

k8s-ci-robot assigned VineethReddy02 Mar 14, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2020

k8s-ci-robot merged commit a534370 into kubernetes:dev-1.18 Mar 14, 2020

pod-overhead: updates for beta #19059

pod-overhead: updates for beta #19059

Uh oh!

Conversation

egernst commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8sio-netlify-preview-bot commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

makoscafee commented Feb 19, 2020

Uh oh!

irvifa commented Mar 3, 2020

Uh oh!

egernst commented Mar 3, 2020

Uh oh!

irvifa commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sftim commented Mar 4, 2020

Uh oh!

sftim commented Mar 4, 2020

Uh oh!

irvifa commented Mar 6, 2020

Uh oh!

egernst commented Mar 7, 2020

Uh oh!

VineethReddy02 commented Mar 7, 2020

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sftim Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

egernst commented Mar 9, 2020

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

tallclair left a comment

Choose a reason for hiding this comment

Uh oh!

tallclair Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

egernst Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

egernst commented Mar 10, 2020

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

egernst commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VineethReddy02 commented Mar 12, 2020

Uh oh!

egernst commented Mar 13, 2020

Uh oh!

tallclair left a comment

Choose a reason for hiding this comment

Uh oh!

derekwaynecarr commented Mar 13, 2020

Uh oh!

irvifa commented Mar 14, 2020

Uh oh!

egernst commented Feb 10, 2020 •

edited

Loading

k8sio-netlify-preview-bot commented Feb 10, 2020 •

edited

Loading

irvifa commented Mar 3, 2020 •

edited

Loading

egernst commented Mar 11, 2020 •

edited

Loading