Skip to content

Update sig-node KubeletPSI test focus to include Feature label #35613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update sig-node KubeletPSI test focus to include Feature label #35613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ presubmits:
- '--node-test-args=--feature-gates=KubeletPSI=true --service-feature-gates=KubeletPSI=true --container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/home/containerd/usr/local/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service"'
- --node-tests=true
- --provider=gce
- --test_args=--nodes=8 --focus="Summary API"
- --test_args=--nodes=8 --focus="Summary API|\[Feature:KubeletPSI\]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is being removed in this PR: kubernetes/kubernetes#134303

Why would this needs to be added here?

Also it is a beta FG enabled by default that doesn't need a special environment to run. All tests like this will execute as part of a regular NodeConformance tests execution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mariafromano-25

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I believe ater merging kubernetes/kubernetes#134303 you will be able to confirm that all tests are executed as part of regular jobs and this job can be completely removed

- --timeout=65m
env:
- name: GOPATH
Expand Down