Skip to content

Add external-snapshot-metadata repo to CSI jobs #33303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2024
Merged

Add external-snapshot-metadata repo to CSI jobs #33303

merged 3 commits into from
Oct 11, 2024

Conversation

@hairyhum
Copy link
Contributor

@hairyhum hairyhum commented Aug 12, 2024

Added external-snapshot-metadata to config/jobs/kubernetes-csi/gen-jobs.sh and config/jobs/image-pushing/k8s-staging-sig-storage.sh and generated the jobs.

Added external-snapshot-metadata to config/testgrids/kubernetes/sig-storage/config.yaml dashboards.

This is a part of setting up the CI for https://github.com/kubernetes-csi/external-snapshot-metadata

Related:
kubernetes-csi/external-snapshot-metadata#19
kubernetes-csi/external-snapshot-metadata#6

I might have missed or misconfigured something, so would appreciate any feedback.

@hairyhum
Add external-snapshot-metadata repo to CSI jobs
4f0b35d 
Added `external-snapshot-metadata` to `config/jobs/kubernetes-csi/gen-jobs.sh`
and `config/jobs/image-pushing/k8s-staging-sig-storage.sh` and generated the jobs

Added `external-snapshot-metadata` to `config/testgrids/kubernetes/sig-storage/config.yaml` dashboards
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 12, 2024

Welcome @hairyhum!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 12, 2024

Hi @hairyhum. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and saad-ali August 12, 2024 21:19
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 12, 2024
@hairyhum
Copy link
Contributor Author

hairyhum commented Aug 12, 2024

@xing-yang can you please take a look?

@xing-yang
Copy link
Contributor

xing-yang commented Aug 21, 2024

/assign

@xing-yang
Copy link
Contributor

xing-yang commented Aug 21, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2024
@hairyhum
Copy link
Contributor Author

hairyhum commented Aug 28, 2024

@xing-yang all tests look green, can you do a review?

xing-yang
xing-yang reviewed Sep 10, 2024
View reviewed changes
config/jobs/kubernetes-csi/external-snapshot-metadata/external-snapshot-metadata-config.yaml
@@ -0,0 +1,433 @@
# generated by gen-jobs.sh, do not edit manually
Copy link
Contributor

@xing-yang xing-yang Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file generated by running gen-jobs.sh? We recently updated K8s versions in gen-jobs.sh. Please re-run it. We should have jobs for 1.29-1.31.

Copy link
Contributor Author

@hairyhum hairyhum Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerated.

@hairyhum
Copy link
Contributor Author

hairyhum commented Sep 12, 2024

@xing-yang ready for another review

@hairyhum hairyhum requested a review from xing-yang September 12, 2024 20:38
@hairyhum hairyhum mentioned this pull request Sep 18, 2024
Closed
11 tasks
@xing-yang
Copy link
Contributor

xing-yang commented Oct 2, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@hairyhum
Copy link
Contributor Author

hairyhum commented Oct 7, 2024

/assign mpherman2

@hairyhum
Copy link
Contributor Author

hairyhum commented Oct 7, 2024

/assign saad-ali

@hairyhum
Copy link
Contributor Author

hairyhum commented Oct 9, 2024

@xing-yang @saad-ali @mpherman2 can this move forward? Anything else required from my side?

@xing-yang
Copy link
Contributor

xing-yang commented Oct 11, 2024

/assign @msau42

@xing-yang
Copy link
Contributor

xing-yang commented Oct 11, 2024

@dims Can you help approve this?
/assign @dims

@dims
Copy link
Member

dims commented Oct 11, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hairyhum, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit e8871c0 into kubernetes:master Oct 11, 2024
5 checks passed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 11, 2024

@hairyhum: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-sig-storage.yaml using file config/jobs/image-pushing/k8s-staging-sig-storage.yaml
  • key external-snapshot-metadata-config.yaml using file config/jobs/kubernetes-csi/external-snapshot-metadata/external-snapshot-metadata-config.yaml

In response to this:

Added external-snapshot-metadata to config/jobs/kubernetes-csi/gen-jobs.sh and config/jobs/image-pushing/k8s-staging-sig-storage.sh and generated the jobs.

Added external-snapshot-metadata to config/testgrids/kubernetes/sig-storage/config.yaml dashboards.

This is a part of setting up the CI for https://github.com/kubernetes-csi/external-snapshot-metadata

Related:
kubernetes-csi/external-snapshot-metadata#19
kubernetes-csi/external-snapshot-metadata#6

I might have missed or misconfigured something, so would appreciate any feedback.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Rakshith-R
Rakshith-R reviewed Oct 21, 2024
View reviewed changes
config/jobs/image-pushing/k8s-staging-sig-storage.yaml
Comment on lines +341 to +344
branches:
# For publishing canary images.
- ^master$
- ^release-
Copy link

@Rakshith-R Rakshith-R Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hairyhum @xing-yang ,

The development branch for https://github.com/kubernetes-csi/external-snapshot-metadata is main and not master master as with other sidecars.

The build job will not get triggered due to this difference ?

https://github.com/kubernetes-csi/external-snapshot-metadata
I don't this job being triggered for the pr that merged 3 days ago.

cc @PrasadG193 @carlbraganza

@hairyhum hairyhum mentioned this pull request Oct 21, 2024
Merged
@Rakshith-R Rakshith-R mentioned this pull request Mar 4, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

1 more reviewer

@Rakshith-R Rakshith-R Rakshith-R left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@xing-yang xing-yang

@saad-ali saad-ali

@msau42 msau42

@mpherman2 mpherman2

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hairyhum @k8s-ci-robot @xing-yang @dims @Rakshith-R @saad-ali @msau42 @mpherman2