Skip to content

Conversation

@akhilerm
Copy link
Member

  • add separate image config file for containerd-1.5 presubmit. This is because the containerd-main-presubmit uses cos-stable image which uses systemd cgroup driver which is not configured in container 1.5. Therefore, containerd-1.5 job will use cos-93 image (cgroupv1) in presubmit jobs.

Signed-off-by: Akhil Mohan [email protected]

- add separate image config file for containerd-1.5 presubmit.
This is because the containerd-main-presubmit uses cos-stable image
which uses systemd cgroup driver which is not configured in container
1.5. Therefore, containerd-1.5 job will use cos-93 image (cgroupv1)
in presubmit jobs.

Signed-off-by: Akhil Mohan <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @akhilerm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 16, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2022
@bobbypage
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2022
@akhilerm
Copy link
Member Author

/cc @bobbypage @SergeyKanzhelev

@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@akhilerm
Copy link
Member Author

/cc @dims @mikebrow

Can you take a look and approve?

@dims
Copy link
Member

dims commented Nov 16, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, dims, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit e63695f into kubernetes:master Nov 16, 2022
@k8s-ci-robot
Copy link
Contributor

@akhilerm: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd-presubmit-jobs.yaml using file config/jobs/containerd/containerd/containerd-presubmit-jobs.yaml

In response to this:

  • add separate image config file for containerd-1.5 presubmit. This is because the containerd-main-presubmit uses cos-stable image which uses systemd cgroup driver which is not configured in container 1.5. Therefore, containerd-1.5 job will use cos-93 image (cgroupv1) in presubmit jobs.

Signed-off-by: Akhil Mohan [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhilerm akhilerm deleted the use-cos-93-containerd-1.5 branch November 16, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants