investigate if minikube service "is waiting"

[medyagh]

What Happened?

as far as I know "minikube service" command has a logic to wait for the service and pods to be running before displaying the URL to the user,
it is possible that minikube service is not doing the right "waiting" for the service to be up before printing out the URL

resulting in curl $(minikube service example --url) to fail

#13595
medyagh/setup-minikube#29

Attach the log file

n/a

Operating System

None

Driver

None

[shogohida]

Hi @medyagh, can I work on this? I'm new to minikube so I might need your help while dealing with this issue.

[shogohida]

Should I check the code around here?

https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/service.go#L123

[elizabeth-dev]

Hi, I've been investigating on this issue, and it is true that minikube service is not waiting for the pods to be available. I tried looking for a solution, but since we check the k8s API for services, and there's no status info for the pods in there (not even a health check we could use as a workaround), there's no right away solution.

We could get the service selector and query the pods serving it, checking if there's at least one running, but that seems a bit too coupled to me, so I'd like a maintainer's opinion on that.

On a side note, while checking this issue, I noticed that we are not honoring the --wait argument, even though the logic is in there, so I opened a PR for that: #15735

[Sajiyah-Salat]

I think this issue is fixed so It should be closed.

[Ritikaa96]

@kubernetes/minikube-maintainers

[Ritikaa96]

The PR had resolved the above issue as per me, we can take a second opinion from maintainers before it is closed though.

[konstantinoskolios]

Close this ticket please 👍

[prezha]

@konstantinoskolios, thanks for the bump, i'm going to close ths really old issue, as we've already confirmed it working and the fixing #15735 pr was merged