-
Notifications
You must be signed in to change notification settings - Fork 41.7k
DRA: Fix incorrect behavior for AllocationMode: All in ResourceClaim when used in subrequests #131660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA: Fix incorrect behavior for AllocationMode: All in ResourceClaim when used in subrequests #131660
Conversation
…when used in subrequests
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/wg device-management |
| deviceAllocationResult(req0, driverA, pool1, device1, false), | ||
| )}, | ||
| }, | ||
| "prioritized-list-allocation-mode-all": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails without the fix, as intended.
/lgtm
/approve
No need to backport, it only affects the firstAvailable feature.
|
LGTM label has been added. Git tree hash: c5f4b9d67430e76fb28cbcb8cf12e3a7babec572
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mortent, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The DRA allocator doesn't deallocate previously allocated devices when allocation fails with AllocationMode All. This was correct before we added the PrioritizedList feature, since failing to allocate all devices on the node meant allocation on that node had failed. But with PrioritizedList, there might be other subrequests that need to be attempted, and for that we need devices to be correctly deallocated.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: