Require canonicalization of NetworkDeviceData IPs

[danwinship]

What this PR does / why we need it:

Validates NetworkDeviceData more strictly. There's no reason to allow non-standard or non-canonical IP values in new APIs.

Which issue(s) this PR fixes:

None, but related to KEP-4858 (kubernetes/enhancements#4899) and #128786

Does this PR introduce a user-facing change?

When using the Alpha DRAResourceClaimDeviceStatus feature, IP address values
in the NetworkDeviceData are now validated more strictly.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/4858

/kind bug
/sig network
/cc @aojea
/assign @LionelJouin

[aojea]

note , but I find this helpers very difficult to reason about

[aojea]

ok, I got it now, the first function validats, the second function checsk for dupes

[aojea]

note to self, this just do the same , parse the cidr, but throws the expected Errorlist

kubernetes/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go

Lines 402 to 409 in 21525f3

	func IsValidCIDR(fldPath *field.Path, value string) field.ErrorList {
	var allErrors field.ErrorList
	_, _, err := netutils.ParseCIDRSloppy(value)
	if err != nil {
	allErrors = append(allErrors, field.Invalid(fldPath, value, "must be a valid CIDR value, (e.g. 10.9.8.0/24 or 2001:db8::/64)"))
	}
	return allErrors
	}

[aojea]

/lgtm
/approve

good catch

/assign @thockin

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b27063b6d83674146d8c27ad57c5d1f47937e1e6

[aojea]

/approve

can I?

[pohly]

/label api-review
/priority important-soon
/triage accepted

This blocks promotion to beta in 1.33.

[thockin]

@yongruilin @aaron-prindle another one :)

[aojea]

Kubernetes e2e suite: [It] [sig-cli] Kubectl client Simple pod should return command exit codes should handle in-cluster config expand_more

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 032dd381c867f92ac4b0f3712c0b0e0ee9ea5e14

[aojea]

/test pull-kubernetes-e2e-gce

failed test is unrelated

[thockin]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship, LionelJouin, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment