Skip to content

KEP-3926: Add a test to verify list error aggregation #129129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP-3926: Add a test to verify list error aggregation #129129

wants to merge 2 commits into from
+512 −31

Conversation

@tkashem
Copy link
Contributor

@tkashem tkashem commented Dec 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds a unit test for storage GetList to verify that list error aggregation works as expected

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/pull/3927

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2024

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Dec 9 18:07:08 UTC 2024.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 9, 2024
@tkashem tkashem changed the title KEP-3926:: Add a test to verify list error aggregation KEP-3926: Add a test to verify list error aggregation Dec 9, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 9, 2024
@tkashem tkashem mentioned this pull request Dec 9, 2024
Open
8 tasks
@Jefftree
Copy link
Member

Jefftree commented Dec 10, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2024
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch 2 times, most recently from 3a88a9b to be5804c Compare December 12, 2024 21:11
@liggitt liggitt requested review from deads2k and removed request for caesarxuchao and liggitt December 18, 2024 15:05
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch 2 times, most recently from 7dc067b to 3b32926 Compare February 14, 2025 17:40
@tkashem
Copy link
Contributor Author

tkashem commented Feb 17, 2025

stress test result:

❯ go test -race k8s.io/apiserver/pkg/storage/etcd3 -c
❯ stress -p=64 ./etcd3.test -test.run=TestGetListWithErrorAggregation
5s: 0 runs so far, 0 failures
10s: 0 runs so far, 0 failures
15s: 5 runs so far, 0 failures
20s: 64 runs so far, 0 failures
...
7m0s: 1643 runs so far, 0 failures
7m5s: 1666 runs so far, 0 failures
7m10s: 1682 runs so far, 0 failures

@tkashem
Copy link
Contributor Author

tkashem commented Feb 26, 2025

/cc @dgrisonnet

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sttts March 7, 2025 14:03
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch from d059f69 to 7c8c15a Compare March 10, 2025 12:45
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2025
ibihim
ibihim reviewed Jul 23, 2025
View reviewed changes
@dims dims added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 5, 2025
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch from 7c8c15a to 40da582 Compare September 22, 2025 18:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2025
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch 3 times, most recently from ab1d286 to 7b7decd Compare September 25, 2025 16:30
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2025
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch from 7b7decd to 9dabd7f Compare September 25, 2025 16:32
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch from 9dabd7f to 312a580 Compare September 26, 2025 20:48
ibihim
ibihim reviewed Oct 1, 2025
View reviewed changes
@tkashem tkashem force-pushed the test-get-list-error-aggregation branch from 312a580 to 3e35e51 Compare October 2, 2025 14:27
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hashim21223445, tkashem
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibihim
Copy link
Contributor

ibihim commented Oct 15, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2025

LGTM label has been added.

Git tree hash: e0fb772b066f401611aa3d1ce40f72a275e608dc

@tkashem
Copy link
Contributor Author

tkashem commented Oct 16, 2025

/cc @wojtek-t @serathius

@ibihim
Copy link
Contributor

ibihim commented Oct 20, 2025

/assign @enj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

@sttts sttts Awaiting requested review from sttts

@serathius serathius Awaiting requested review from serathius

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

3 more reviewers

@ibihim ibihim ibihim left review comments

@dgrisonnet dgrisonnet dgrisonnet left review comments

@hashim21223445 hashim21223445 hashim21223445 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@enj enj

@ibihim ibihim

Labels

area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tkashem @k8s-ci-robot @Jefftree @ibihim @dgrisonnet @hashim21223445 @dims @enj