Skip to content

MVP cleanup #2 #122957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

MVP cleanup #2 #122957

merged 1 commit into from
Oct 3, 2024

Conversation

@richabanker
Copy link
Contributor

@richabanker richabanker commented Jan 25, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refactor for better readability.

  1. Remove struct serviceableByResponse and refactor findServiceableByServers() to just return the IDs of shortlisted apiservers for proxying the request
  2. Move the logic to fetch hostport info for a particular apiserver under resolveServingLocation()
  3. Add a new test for the scenario when when 2 apiservers are identified as candidates to proxy a resource request to, but for one of those apiservers either: the endpoint lease is not available or the endpoint lease has invalid hostport info in it. In this case, the request should be routed to the other apiserver for which we have the correct hostport info available.

Which issue(s) this PR fixes:

Issue #kubernetes/enhancements#4020

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dims January 25, 2024 04:00
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/test needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2024
@richabanker richabanker changed the title Uvip bugfix UVIP bugfix for routing a request to the second valid apiserver if the first one has incorrect hostport info in its endpoint lease Jan 25, 2024
@richabanker richabanker force-pushed the uvip-bugfix branch 2 times, most recently from 63d5342 to d5a0709 Compare January 25, 2024 04:50
@dgrisonnet
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jan 25, 2024
@jiahuif
Copy link
Contributor

jiahuif commented Jan 25, 2024

/assign @jpbetz
Thank you.
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2024
@richabanker richabanker force-pushed the uvip-bugfix branch 2 times, most recently from 83c5a7e to da2142c Compare January 26, 2024 20:54
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2024
@richabanker richabanker changed the title UVIP bugfix for routing a request to the second valid apiserver if the first one has incorrect hostport info in its endpoint lease MVP cleanup #2 Sep 28, 2024
@richabanker richabanker force-pushed the uvip-bugfix branch 3 times, most recently from dbd8869 to b68abc4 Compare October 1, 2024 20:19
@richabanker
Copy link
Contributor Author

/assign
@Jefftree @jpbetz
This is the last cleanup for MVP (hopefully), needed before we can try to get #127640 in (once its ready to be merged)

Jefftree
Jefftree reviewed Oct 1, 2024
View reviewed changes
@Jefftree
Copy link
Member

Jefftree commented Oct 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5818f8321f59bf283dbc5faa00eb1292bd2778c6

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@Jefftree
Copy link
Member

Jefftree commented Oct 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aa4a3452a6ec03ccb805e91cbc99539071ba89fe

jpbetz
jpbetz approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3660a34 into kubernetes:master Oct 3, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 3, 2024
@richabanker richabanker mentioned this pull request Oct 4, 2024
Closed
@aojea aojea mentioned this pull request Oct 5, 2024
Closed
@richabanker richabanker deleted the uvip-bugfix branch October 7, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@Jefftree Jefftree Awaiting requested review from Jefftree

1 more reviewer

@jpbetz jpbetz jpbetz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpbetz jpbetz

@Jefftree Jefftree

@richabanker richabanker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

7 participants

@richabanker @dgrisonnet @jiahuif @k8s-triage-robot @k8s-ci-robot @Jefftree @jpbetz