Skip to content

test/e2e: Fix flaking subresource test #116619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

test/e2e: Fix flaking subresource test #116619

merged 1 commit into from
Mar 15, 2023

Conversation

@MadhavJivrajani
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani commented Mar 14, 2023

What type of PR is this?

/kind flake

What this PR does / why we need it:

Avoid comparing fields that might end up changing
between two invocations of kubectl.

Which issue(s) this PR fixes:

Fixes #116614

Special notes for your reviewer:

I also thought of only comparing the headers, but thought this might be better. Happy to revise the approach.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2590-kubectl-subresource

/cc @aojea
/assign @soltysh

@MadhavJivrajani
test/e2e: Fix flaking subresource test
87b6474 
Avoid comparing fields that might end up changing
between two invocations of kubectl.

Signed-off-by: Madhav Jivrajani <[email protected]>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from aojea March 14, 2023 22:15
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 14, 2023

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2023
@MadhavJivrajani
Copy link
Contributor Author

MadhavJivrajani commented Mar 14, 2023

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 14, 2023
@MadhavJivrajani
Copy link
Contributor Author

MadhavJivrajani commented Mar 14, 2023

/cc @SergeyKanzhelev

@aojea
Copy link
Member

aojea commented Mar 14, 2023

/assign @seans3

can you ptal? it maybe late for Maciej

Thanks for the quick fix

SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward change

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 14, 2023

LGTM label has been added.

Git tree hash: 7f6db4d3ba44f93400690799053470bc0a302d94

@dims
Copy link
Member

dims commented Mar 14, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
liggitt
liggitt reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
just to deflake master for code freeze, but I don't think empty strings passed to checkOutput make sense

a follow-up to make this output structured data with -o jsonpath would be more reliable and more correct

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, MadhavJivrajani, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea aojea mentioned this pull request Mar 14, 2023
Merged
@cici37 cici37 added this to the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2c8dffd into kubernetes:master Mar 15, 2023
@nikhita nikhita mentioned this pull request Mar 15, 2023
Closed
12 tasks
@MadhavJivrajani MadhavJivrajani mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@aojea aojea Awaiting requested review from aojea

+1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@soltysh soltysh

@seans3 seans3

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.27

9 participants

@MadhavJivrajani @k8s-ci-robot @aojea @dims @liggitt @SergeyKanzhelev @soltysh @seans3 @cici37