be able to run defaulter-gen tests via go test
#245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files whose names begin with "_" are ignored by go test so none of the defaulter-gen tests were running in CI. This commit renames `_output_tests` to `output_tests` so that tests are run. After doing so, tests failed because some packages missed a `fake_deepcopy_conversion.go` file. This is necessary because types registered in the scheme need to implement the `DeepCopyObject()` method. Additionally, some of the tests import `k8s.io/api` and `k8s.io/apimachinery` so these are also added to `go.mod`.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
alexzielenski
changed the title
go testgo test
alexzielenski
changed the title
go testgo test
Member
Author
|
/cc @sttts |
apelisse
reviewed
Aug 17, 2023
Member
apelisse
left a comment
apelisse
left a comment
There was a problem hiding this comment.
Thanks, that's definitely confusing. Can we get a comment somewhere to indicate what's going on without having to go through the github history?
Member
Author
|
updated PR description and added comment |
Member
Author
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Aug 23, 2023
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #240 which went stale and closed.
Took into account some of the feedback provided on that PR, keeping
_output-testsbut adding its own go.mod so there can be a dependency on k/k packages directly without forming a cycle.Changes from initial PR:
output_testsback to_output_tests_output_teststooutput_tests- otherwise retaining underscore in go package name caused ambiguous import error with gengo's file tree:The module name itself still needed the underscore removed otherwise would get this error:
I think since this PR adds a new go module CI would need to be updated to run it. This PR makes
go test ./...from within_output_testscorrectly run without hacks.