Skip to content

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Mar 7, 2025

/assign @ardaguclu

Signed-off-by: Maciej Szulik <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2025
@soltysh soltysh mentioned this pull request Mar 7, 2025
12 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Mar 7, 2025
@ardaguclu
Copy link
Member

/lgtm
/hold
unhold whenever you're fine

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 7, 2025
@soltysh
Copy link
Contributor Author

soltysh commented Mar 7, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 66a23db into kubernetes:master Mar 7, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 7, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Mar 7, 2025
@soltysh soltysh deleted the subresource_implemented branch March 7, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants