KEP-2590: update supported subresources list #5179
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/kep
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/cli
12 tasks
ardaguclu
reviewed
Feb 18, 2025
| This document proposes adding a new `--subresource` flag to the following kubectl | ||
| subcommands: `get`, `patch`, `edit`, `apply` and `replace`. The goal of this flag | ||
| is to simplify the process of fetching and updating `status` and `scale` subresources. | ||
| is to simplify the process of fetching and updating `status`, `scale` and `resize` |
Member
There was a problem hiding this comment.
Would it be better if we add resize KEP in kep.yaml references?
Contributor
Author
There was a problem hiding this comment.
Member
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
Signed-off-by: Maciej Szulik <[email protected]>
soltysh
force-pushed
the
subresource_update
branch
from
afd35d2 to
8186447
Compare
Contributor
Author
|
/hold cancel |
k8s-ci-robot
added
size/S
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resizesubresource which was added in [FG:InPlacePodVerticalScaling] Remove restrictions on subresource flag in kubectl commands kubernetes#128296/assign @ardaguclu