Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-apps/3998.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"
Comment on lines +6 to +7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @wojtek-t!
Would you mind taking this graduation as PRR approver?
Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I was out for last 3 weeks. Taking a look now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Thanks for the review!

8 changes: 4 additions & 4 deletions keps/sig-apps/3998-job-success-completion-policy/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors:
owning-sig: sig-apps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the following updates in the README.md part of this enhancement:

  1. Check appropriate boxes in the Release Signoff Checklist
  2. You'll want to update integration and e2e tests sections with links to triage board, see template.
  3. One of the GA criteria mentions mentions verifying Complete condition, what are the plans? I'd expect at this point in time this wording to be change do we will or we won't.
  4. Update Implementation history with this edit information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check those, then share them with you here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh I addressed them in 9b465bb.

Regarding 4, it would be better to "will do" in this GA graduation since we introduced the dedicated Completions reason, CompletionsReached for exiting Completions behavior and SuccessPolicy for new Completions with SuccessPolicy behavior.

participating-sigs:
- sig-apps
status: implementable
status: implemented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this, yet. If this slips 1.33 this will be misleading. We usually update this field after the release, while closing the issue tracking a particular feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I did not know that. I will revert this change. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 9585ac6

creation-date: 2023-06-05
reviewers:
- "@mimowo"
Expand All @@ -21,18 +21,18 @@ see-also:
- "/keps/sig-apps/4368-support-managed-by-batch-job"

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.31"
latest-milestone: "v1.33"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.30"
beta: "v1.31"
stable:
stable: "v1.33"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down