Skip to content

KEP-3094: Graduate NodeInclusionPolicyInPodTopologySpread to GA #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

KEP-3094: Graduate NodeInclusionPolicyInPodTopologySpread to GA #4912

merged 3 commits into from
Feb 12, 2025

Conversation

@kerthcet
Copy link
Member

@kerthcet kerthcet commented Oct 9, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2024
@kerthcet kerthcet mentioned this pull request Oct 9, 2024
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Oct 9, 2024

Also cc @wojtek-t as the PRR approver, thanks!

@wojtek-t wojtek-t self-assigned this Oct 11, 2024
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jan 9, 2025

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2025
@kerthcet
Copy link
Member Author

kerthcet commented Feb 7, 2025

Will update later.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 10, 2025

I'm fine with this change from PRR pov, but please update and have the SIG approval first and then ping me for approval.

@kerthcet
Copy link
Member Author

kerthcet commented Feb 10, 2025

Thanks @wojtek-t I'm just updating the kep the same time.

@kerthcet kerthcet force-pushed the feat/graduate-to-ga branch from da92362 to 853122b Compare February 10, 2025 09:07
@kerthcet
Copy link
Member Author

kerthcet commented Feb 10, 2025

ping @alculquicondor @Huang-Wei for sig review.

kerthcet
kerthcet commented Feb 10, 2025
View reviewed changes
keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md
- `pkg/api/pod`: `2025-02-10` - `79.1%`
- `pkg/apis/core/validation`: `2025-02-10` - `84.4%`
- `pkg/scheduler`: `2025-02-10` - `80.7%`
- `pkg/scheduler/framework/plugins/defaultpreemption`: `2025-02-10` - `80.4%`
Copy link
Member Author

@kerthcet kerthcet Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A went down for pkg/scheduler/framework/plugins/defaultpreemption.

@wojtek-t wojtek-t removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2025
@wojtek-t
Copy link
Member

wojtek-t commented Feb 11, 2025

/approve PRR

@Huang-Wei
Copy link
Member

Huang-Wei commented Feb 11, 2025

/approve
on scheduling side.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, kerthcet, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@kerthcet
Copy link
Member Author

kerthcet commented Feb 12, 2025

/approve on scheduling side.

We still need a LGTM, are you waiting for other suggestions, wei? PRR approval is tagged.

@Huang-Wei
Copy link
Member

Huang-Wei commented Feb 12, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8e392b3 into kubernetes:master Feb 12, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 12, 2025
@kerthcet
Copy link
Member Author

kerthcet commented Feb 12, 2025

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

1 more reviewer

@Huang-Wei Huang-Wei Huang-Wei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Huang-Wei Huang-Wei

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

5 participants

@kerthcet @k8s-triage-robot @wojtek-t @Huang-Wei @k8s-ci-robot