-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-4444: Update PRR sections for beta release targeting 1.31 #4659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4444: Update PRR sections for beta release targeting 1.31 #4659
Conversation
75b25e0 to
77ec022
Compare
|
/assign @aojea @danwinship @thockin |
| # The milestone at which this feature was, or is targeted to be, at each stage. | ||
| milestone: | ||
| alpha: "v1.30" | ||
| # beta: "v1.31" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to uncomment this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for catching that! Uncommented.
77ec022 to
bc573d0
Compare
robscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gauravkghildiyal! One tiny nit but otherwise LGTM.
|
/lgtm |
|
/approve |
aa41e19 to
aeb9877
Compare
|
(Rebased) |
|
/lgtm |
|
Hi @johnbelamaric! Dropping in a reminder for a PRR review (the freeze is soon approaching in a week) Thanks |
johnbelamaric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, but PRR looks really good. Thanks!
/hold for sig approval
/approve for PRR
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, johnbelamaric, robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I see sig-net is already there. Would be nice to clean out that one paragraph though, then you can unhold... |
|
Thanks for the review, John! I've incorporated the suggestions. /unhold |
|
/lgtm |
/sig network
/cc @robscott
/assign @aojea, @danwinship, @thockin
PRR reviewers:
/assign @johnbelamaric