Skip to content

KEP-2590: graduate kubectl subresource support to stable #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

KEP-2590: graduate kubectl subresource support to stable #4468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-cli/2590.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ kep-number: 2590
alpha:
approver: "@johnbelamaric"
beta:
approver: "@johnbelamaric"
stable:
approver: "@johnbelamaric"
24 changes: 23 additions & 1 deletion keps/sig-cli/2590-kubectl-subresource/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ to implement this enhancement.

##### e2e tests

- e2e test added:
- [Link to testgrid](https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-e2e-gci-gce&include-filter-by-regex=kubectl%20subresource)
- [Link to test](https://github.com/kubernetes/kubernetes/blob/11b974043604f5ccbeb6e5e62e1d9edcf00bc336/test/e2e/kubectl/kubectl.go#L2101)

### Graduation Criteria

#### Alpha
Expand All @@ -234,7 +238,11 @@ to implement this enhancement.

#### GA

- User feedback gathered for at least 1 cycle.
Since v1.27 when the feature moved to beta, there have been no reported bugs concerning this feature.
In fact, it is reassuring to see the community use this feature quite commonly such as in bug reports:
https://github.com/kubernetes/kubernetes/issues/116311

Seeing this and given our added unit, integration and e2e tests gives us the confidence to graduate to GA.


### Upgrade / Downgrade Strategy
Copy link
Member

@enj enj Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all the relevant PRR/version skew sections to consider server side changes like kubernetes/kubernetes#103516

Expand Down Expand Up @@ -332,10 +340,17 @@ No.

### Monitoring Requirements

Considering that this feature is a flag contained fully within in the `kubectl` client, there exist no
monitoring requirements for the same.
Comment on lines +343 to +344
Copy link
Member

@enj enj Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true, this KEP required server side changes. For example, kubernetes/kubernetes#103516 was added in v1.24. From that PR, I do not see any generic integration test that was added to make sure that all scale sub-resources continue to support tables going forward. This needs to be added to prevent the feature from regressing in the future for new built-in types. This is not an issue for CRDs because they all use the same code path. This is (generally) not an issue for the status sub-resource because that uses the same code path as the regular resource, but it may be good to add an integration test just in case.


###### How can an operator determine if the feature is in use by workloads?

N/A

###### How can someone using this feature know that it is working for their instance?

N/A
Copy link
Member

@enj enj Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I use the kube audit logs to find instances of kubectl interacting with sub-resources? Not sure why I would need to do that, but can I?


###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?

N/A
Expand Down Expand Up @@ -388,6 +403,10 @@ No

No

###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

No

### Troubleshooting

###### How does this feature react if the API server and/or etcd is unavailable?
Expand All @@ -408,6 +427,9 @@ N/A
2021-04-06: KEP proposed
2021-04-07: [Demo] in SIG CLI meeting
2022-05-25: PR for alpha implementation merged
2023-01-12: KEP graduated to Beta
2023-03-15: e2e test added for KEP as part of beta graduation
2024-02-01: KEP graduated to Stable

[POC PR]: https://github.com/kubernetes/kubernetes/pull/99556
[Demo]: https://youtu.be/zUa7dudYCQM?t=299
Expand Down
9 changes: 5 additions & 4 deletions keps/sig-cli/2590-kubectl-subresource/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ approvers:
- "@soltysh"

creation-date: 2021-04-06
last-updated: 2023-01-12
last-updated: 2024-02-01

status: implementable
stage: beta
status: implemented
stage: stable

latest-milestone: "v1.27"
latest-milestone: "v1.30"

milestone:
alpha: "v1.24"
beta: "v1.27"
stable: "v1.30"