Skip to content

Make ContainerD logs to file #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Make ContainerD logs to file #512

merged 1 commit into from
Oct 28, 2025
+244 −14

Conversation

@zylxjtu
Copy link
Contributor

@zylxjtu zylxjtu commented Aug 28, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 28, 2025
@marosset
Copy link
Contributor

marosset commented Aug 28, 2025

@zylxjtu - can we remove the KPNG stuff as a separate PR?
And also if we remove that then please update https://github.com/kubernetes-sigs/windows-testing/tree/master/capz#optional too

marosset
marosset reviewed Aug 28, 2025
View reviewed changes
capz/templates/shared-image-gallery-ci.yaml Outdated
}
containerd.exe --version
containerd-shim-runhcs-v1.exe --version
- content: "$ErrorActionPreference = 'Stop'\n$$CONTAINERD_URL=\"${WINDOWS_CONTAINERD_URL}\"\nif($$CONTAINERD_URL
Copy link
Contributor

@marosset marosset Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why the formatting is getting mangled now in the generated templates?

Copy link
Contributor Author

@zylxjtu zylxjtu Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I have tried to remove the "\n" but it does not seem to make much difference. so I'm guessing this is the issue of diff instead of real ones?

marosset
marosset reviewed Aug 28, 2025
View reviewed changes
capz/run-capz-e2e.sh

# apply additional helper manifests (logger etc)
kubectl apply -f "${CAPZ_DIR}"/templates/addons/windows/containerd-logging/containerd-logger.yaml
if [[ -n "$CONTAINERD_LOGGER" ]]; then
Copy link
Contributor

@marosset marosset Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now optional but is the intention to continue running the containerd logger?
IIRC it also logs ETW events for HCS which can be useful in debugging which containerd doesn't log.
@jsturtevant WDYT of these changes?

Copy link
Contributor Author

@zylxjtu zylxjtu Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the intent is to remove this logger pod if we have can have containerd log to files.

Copy link
Contributor

@marosset marosset Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll potentially miss some etw events from HCS / Windows.
Are we OK with that?

Copy link
Contributor Author

@zylxjtu zylxjtu Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my limited experience, we did not check the HCS/windows log often. and we will have scripts to collect corresponding logs for further investigations if needed

@zylxjtu
Copy link
Contributor Author

zylxjtu commented Aug 28, 2025

@zylxjtu - can we remove the KPNG stuff as a separate PR? And also if we remove that then please update https://github.com/kubernetes-sigs/windows-testing/tree/master/capz#optional too

I will move this to a separate PR

zylxjtu
zylxjtu commented Aug 28, 2025
View reviewed changes
capz/templates/gmsa-ci.yaml Outdated
template:
spec:
additionalTags:
AzSecPackAutoConfigReady: "true"
Copy link
Contributor Author

@zylxjtu zylxjtu Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can be removed, not applicable universally

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 28, 2025
@zylxjtu zylxjtu requested a review from marosset October 17, 2025 18:06
@marosset
Copy link
Contributor

marosset commented Oct 20, 2025

/test pull-e2e-capz-windows-2022-extension
/hold for ci
Let's run the test one more time

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@marosset
Copy link
Contributor

marosset commented Oct 20, 2025

/lgtm
/approve
We can unhold after CI runs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Oct 28, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Oct 28, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit b03e1b1 into kubernetes-sigs:master Oct 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

Assignees

@marosset marosset

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zylxjtu @marosset @k8s-ci-robot