Flex volumes plugins readonly alternative path

[danilo404]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes a problem in which setting the variable kubelet_flexvolumes_plugins_dir had no effect. Also introduces some changes to improve how the path is detected to be readonly and remove a hardcoded value from the task itself.

Which issue(s) this PR fixes:

Fixes #5786

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Users of CoreOS and other systems where the default kubelet_flexvolumes_plugins_dir is not writeable can now use an alternative one with kubelet_flexvolumes_plugins_ro_alt_dir

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danilo404
To complete the pull request process, please assign miouge1
You can assign the PR to them by writing /assign @miouge1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bozzo]

/lgtm

[Miouge1]

I went back to check #4999

I am a bit puzzled about this. Wouldn't it be appropriate to simply show an error message "kubelet_flexvolumes_plugins_dir not writable" and call it a day? :D

[danilo404]

I went back to check #4999

I am a bit puzzled about this. Wouldn't it be appropriate to simply show an error message "kubelet_flexvolumes_plugins_dir not writable" and call it a day? :D

I would also say so but I didn't want to break functionality :)

[Miouge1]

The problem being existing clusters on CoreOS & Flatcar Linux?

[danilo404]

The problem being existing clusters on CoreOS & Flatcar Linux?

Yes, but now that you asked, this looks like it would be better to create a note in the updates or the release docs and not work around this, right?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[EppO]

/remove-lifecycle rotten

[k8s-ci-robot]

@danilo404: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[EppO]

Should we put the note in that PR or create a new one?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.