Fix variable for rbd_provisioner_secret #5166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
Member
Author
|
/assign @Atoms |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liupeng0518, riverzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Sep 18, 2019
* 'master' of https://github.com/kubernetes-sigs/kubespray: Add support for k8s v1.14.6 (kubernetes-sigs#5182) Parameterize gcr, quay, and docker image repo defines (kubernetes-sigs#5146) use hyperkubeimage to run controlplane containers (kubernetes-sigs#5178) Update main.yml (kubernetes-sigs#5166) Fixes issue kubernetes-sigs#5160 (kubernetes-sigs#5171) Use more native way to update kubeconfigs using kubeadm (kubernetes-sigs#5165) Fix macro on local_volume_provisioner (kubernetes-sigs#5168) Move cri_socket var to kubespray-defaults (kubernetes-sigs#5149) Add support for k8s v1.16.0-beta.2 (kubernetes-sigs#5148) Fix ansible task titles (kubernetes-sigs#5154) Adjust endpoints for kube-proxy,controller,scheduler to proper ip (kubernetes-sigs#5150) Documenting Terraform variable `az_list` explicitly (kubernetes-sigs#5132) Make haproxy/nginx client timeout configurable (kubernetes-sigs#5140) print hostnames (kubernetes-sigs#5110) Cleanup: fix typo in doc (kubernetes-sigs#5105) Use python3-libselinux on RHEL8/Centos8 (kubernetes-sigs#5127)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Dec 8, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
rbd_provisioner_secret_token is incorrect in defaults/main.yml, the correct one should correspond to the field in yml
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Rename rbd_provisioner_secret_token to rbd_provisioner_secret
the same as #5024