-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix when openstack_cacert starts with a slash #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @peter-c-larsson! |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: peter-c-larsson The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I also got this problem even if OS_CACERT doesn't start with / |
|
Hello, a fix is needed in order for things to work properly. I can create a new PR if the original author can't continue the work. |
|
@alijahnas Feel free to create a new PR since I have some problem to sort out the CLA thing and close this one. Thanks in advance. |
What type of PR is this?
What this PR does / why we need it:
Fix the issue that was introduced with this PR #4665 When having files starting with / causing the following error:
fatal: [kube-node-1]: FAILED! => {"msg": "The conditional check 'openstack_cacert' failed. The error was: template error while templating string: unexpected '/'. String: {% if /etc/ansible/certificate.pem %} True {% else %} False {% endif %}\n\nThe error appears to have been in '/kube-ansible/kubespray/roles/kubernetes/node/tasks/main.yml': line 186, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Write cacert file\n ^ here\n"}Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Discovered in the 2.10.4 branch so I guess this should be backported into that branch as well and not sure about the correct order.
Does this PR introduce a user-facing change?: