Skip to content

Add support for Arm based images in OCI #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

Add support for Arm based images in OCI #821

merged 1 commit into from
Mar 15, 2022

Conversation

@shyamradhakrishnan
Copy link
Contributor

@shyamradhakrishnan shyamradhakrishnan commented Mar 8, 2022

What this PR does / why we need it:
This PR has the necessary changes to build Arm based images on Oracle Cloud Infrastructure.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
Add any other context for the reviewers

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 8, 2022

Hi @shyamradhakrishnan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2022
shyamradhakrishnan
shyamradhakrishnan commented Mar 8, 2022
View reviewed changes
images/capi/ansible/roles/node/meta/main.yml
vars:
rpms: "{{ common_rpms }}"
debs: "{{ common_debs }}"
when: packer_builder_type == "oracle-oci" and ansible_architecture == "aarch64"
Copy link
Contributor Author

@shyamradhakrishnan shyamradhakrishnan Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm does not have the common virt rpms and debs

shyamradhakrishnan
shyamradhakrishnan commented Mar 8, 2022
View reviewed changes
images/capi/ansible/roles/setup/tasks/debian.yml
src: etc/apt/sources.list.j2
dest: /etc/apt/sources.list
mode: 0644
when: packer_builder_type != "oracle-oci"
Copy link
Contributor Author

@shyamradhakrishnan shyamradhakrishnan Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCI Base images has the required apt sources list embedded inside the image. IF we copy the templated file, Arm based build are failing as the sources list is not correct for Arm

Copy link
Contributor

@jsturtevant jsturtevant Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good bit of information to have in a comment so it is not lost in future

Copy link
Contributor Author

@shyamradhakrishnan shyamradhakrishnan Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

@jsturtevant
Copy link
Contributor

jsturtevant commented Mar 8, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2022
@codenrhoden
Copy link
Contributor

codenrhoden commented Mar 10, 2022

overall the changes look fine to me.
/lgtm

I suspect there is some overall refactoring to be done to properly allow a choice of CPU arch -- x86 is pretty much hardcoded across the project for all providers. So I think other providers would run into similar issues around trying to reach common_virt packages that don't exist on ARM.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2022
@jsturtevant
Copy link
Contributor

jsturtevant commented Mar 11, 2022

/lgtm

@codenrhoden
Copy link
Contributor

codenrhoden commented Mar 11, 2022

/approve
@shyamradhakrishnan has mentioned in Slack that he's got a follow-on PR in progress where he can add the requested comment.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, shyamradhakrishnan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@jsturtevant
Copy link
Contributor

jsturtevant commented Mar 11, 2022

azure flake was #766.

ova failed on another PR today to (#825). Not sure if there is something flaky or if it is configuration for ova builds:

vsphere-clone: fatal: [default]: UNREACHABLE! => {"changed": false, "msg": "Failed to create temporary directory.In some cases, you may have been able to authenticate and did not have permissions on the target directory.

/retest

@shyamradhakrishnan
Copy link
Contributor Author

shyamradhakrishnan commented Mar 12, 2022

/test pull-ova-all

3 similar comments
@shyamradhakrishnan
Copy link
Contributor Author

shyamradhakrishnan commented Mar 12, 2022

/test pull-ova-all

@shyamradhakrishnan
Copy link
Contributor Author

shyamradhakrishnan commented Mar 14, 2022

/test pull-ova-all

@shyamradhakrishnan
Copy link
Contributor Author

shyamradhakrishnan commented Mar 15, 2022

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@shyamradhakrishnan shyamradhakrishnan force-pushed the task/oci_arm_support branch 2 times, most recently from 4af1f38 to bddb522 Compare March 15, 2022 08:36
@codenrhoden
Copy link
Contributor

codenrhoden commented Mar 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit cda7418 into kubernetes-sigs:master Mar 15, 2022
@shyamradhakrishnan shyamradhakrishnan mentioned this pull request Jun 16, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@EleanorRigby EleanorRigby Awaiting requested review from EleanorRigby

Assignees

@jsturtevant jsturtevant

@codenrhoden codenrhoden

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shyamradhakrishnan @k8s-ci-robot @jsturtevant @codenrhoden