Skip to content

Fix example as per discussion (should be port, not targetPort) #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix example as per discussion (should be port, not targetPort) #581

merged 1 commit into from
Mar 10, 2021

Conversation

@bowei
Copy link
Contributor

@bowei bowei commented Mar 10, 2021

/kind documentation

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2021
howardjohn
howardjohn approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my 1c/nit: having targetPort in the Service actually shows that the port is the ServicePort. This makes it ambiguous.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bowei
Copy link
Contributor Author

bowei commented Mar 10, 2021

/assign @danehans @robscott

@robscott
Copy link
Member

robscott commented Mar 10, 2021

having targetPort in the Service actually shows that the port is the ServicePort

I agree with this, but think this might be better to solve/document separately. Since this specific example is for upstream TLS, I think we should keep it as simple as possible.

@robscott
Copy link
Member

robscott commented Mar 10, 2021

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit e2b572b into master Mar 10, 2021
@Miciah Miciah mentioned this pull request Aug 16, 2022
Closed
@robscott robscott deleted the ex-fix branch December 2, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robscott robscott Awaiting requested review from robscott

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@howardjohn howardjohn howardjohn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@robscott robscott

@danehans danehans

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bowei @k8s-ci-robot @robscott @howardjohn @danehans