Skip to content

Update CHANGELOG.md #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update CHANGELOG.md #2377

merged 2 commits into from
Sep 5, 2023

Conversation

@LiorLieberman
Copy link
Member

@LiorLieberman LiorLieberman commented Sep 5, 2023 •
edited
Loading

/cc @robscott

What type of PR is this?

/kind cleanup

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2023
robscott
robscott approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 5, 2023
shaneutt
shaneutt reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this actually make it in to v0.8.0 or was it intended for the imminent v0.8.1?

@robscott
Copy link
Member

robscott commented Sep 5, 2023

@shaneutt It made it into v0.8.0 (#2199), I just missed it in the changelog.

@robscott
Copy link
Member

robscott commented Sep 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 59890d6 into kubernetes-sigs:main Sep 5, 2023
@robscott
Copy link
Member

robscott commented Sep 7, 2023

/cherry-pick release-0.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Sep 7, 2023

@robscott: new pull request created: #2378

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaneutt shaneutt shaneutt left review comments

@robscott robscott robscott approved these changes

Assignees

@robscott robscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LiorLieberman @k8s-ci-robot @robscott @k8s-infra-cherrypick-robot @shaneutt