Skip to content

Conversation

@sunjayBhatia
Copy link
Member

What type of PR is this?

/kind cleanup
/kind test
/area conformance

What this PR does / why we need it:

Should be covered by
hack/invalid-examples/gateway/invalid-routability.yaml

Which issue(s) this PR fixes:

Fixes #2208

Does this PR introduce a user-facing change?:

NONE

Should be covered by
hack/invalid-examples/gateway/invalid-routability.yaml

Signed-off-by: Sunjay Bhatia <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2023
@k8s-ci-robot k8s-ci-robot requested review from kflynn and mlavacca July 20, 2023 19:46
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2023
@sunjayBhatia
Copy link
Member Author

/cc @dprotaso

@k8s-ci-robot k8s-ci-robot requested a review from dprotaso July 20, 2023 19:46
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
/approve

@robscott
Copy link
Member

Thanks @sunjayBhatia!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, robscott, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4597f0e into kubernetes-sigs:main Jul 20, 2023
@sunjayBhatia sunjayBhatia deleted the remove-GatewayUnsupportedRoutabilityMutation-test branch July 20, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GatewayUnsupportedRoutabilityMutation test seems unnecessary

4 participants