Skip to content

Conversation

@shaneutt
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

In #1529 we accidentally undid some changes @robscott had made to the Google section of the implementations page. This PR cherry-picks the original commit back on top to fix that mistake while also keeping authorship and attribution intact.

@shaneutt shaneutt added the documentation Improvements or additions to documentation label Nov 14, 2022
@shaneutt shaneutt self-assigned this Nov 14, 2022
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 14, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2022
@shaneutt shaneutt marked this pull request as ready for review November 14, 2022 15:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bowei November 14, 2022 15:30
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

Thanks @shaneutt!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit d1ef4c5 into kubernetes-sigs:main Nov 14, 2022
@shaneutt shaneutt deleted the shaneutt/fix-google-implementation-status branch November 14, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants