-
Notifications
You must be signed in to change notification settings - Fork 617
HTTP rewrite matches the example text #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @subi9! |
|
Hi @subi9. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks! /ok-to-test |
examples/experimental/v1beta1/http-redirect-rewrite/httproute-rewrite.yaml
Outdated
Show resolved
Hide resolved
robscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @subi9! Other than indentation this change LGTM. Please rebase and squash the commits into one with your next update and this should be good to go.
| hostname: elsewhere.example | ||
| path: | ||
| type: ReplacePrefixMatch | ||
| replacePrefixMatch: /fennel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your indentation looks off here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robscott , Tested and fixed the indentation in the yaml file
conformance: add HTTPRoute method matching test
|
/ok-to-test |
|
Hey @subi9, it looks like you need to be using spaces for indentation and not tabs. The actual change LGTM if you are able to fix the indentation and rebase/squash the commits. |
|
HI @robscott , I have rebased and removed the tabs and fixed with proper spaces. Please review. |
|
Thanks @subi9! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, subi9 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
HTTP rewrite example matches with the yaml file example given
Which issue(s) this PR fixes:
Fixes #1338
Does this PR introduce a user-facing change?: