Skip to content

Conversation

@robscott
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Now that we've released v0.5.0, we need to bump our version refs throughout to avoid future API changes being included in CRDs labeled "v0.5.0".

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this change people deploying from main wont get a v0.5.0 version tag, when what they're really getting is main. Some features could make it into main but then back out, meaning that at some point you might deploy v0.6.0-dev which would have a feature in it, but then v0.6.0 would not. Not super likely to happen or be a problem, but just for extra special clarification, would it be reasonable to tag everything as main instead? Would that not be more clear about what they're getting?

@robscott
Copy link
Member Author

So with this change people deploying from main wont get a v0.5.0 version tag

Yep, that's the main goal here, don't want to have things labeled as v0.5.0 that are not that release.

Some features could make it into main but then back out, meaning that at some point you might deploy v0.6.0-dev which would have a feature in it, but then v0.6.0 would not

I personally think that's fine and should be assumed when using something tagged "dev", but I can understand how that could be a poor experience for someone. Maybe we just need clearer documentation around this?

would it be reasonable to tag everything as main instead?

I don't feel that strongly about name, but I slightly prefer the -dev suffix as it represents the release we're working toward and provides some level of context as far as how old the CRD may be. For reference, this matches what we did before the v0.5.0 release where we had a v0.5.0-dev value here. I think one downside of using main as the name is that it could be interpreted as communicating a sense of stability - ie someone might thing that this is that "main" set of CRDs for the project.

I'm fine to add more docs or choose a different name, but I do want to get something in ASAP that will remove the v0.5.0 references from our CRDs so we don't have multiple variations of v0.5.0 CRDs floating around.

Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference for a different name like main where down the road we could start branching for releases rather than having to do manual changes like this, but given that this sentiment isn't shared I also don't feel it's worth blocking over.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 762e874 into kubernetes-sigs:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants