-
Notifications
You must be signed in to change notification settings - Fork 617
Bumping versions to v0.6.0-dev #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shaneutt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with this change people deploying from main wont get a v0.5.0 version tag, when what they're really getting is main. Some features could make it into main but then back out, meaning that at some point you might deploy v0.6.0-dev which would have a feature in it, but then v0.6.0 would not. Not super likely to happen or be a problem, but just for extra special clarification, would it be reasonable to tag everything as main instead? Would that not be more clear about what they're getting?
Yep, that's the main goal here, don't want to have things labeled as v0.5.0 that are not that release.
I personally think that's fine and should be assumed when using something tagged "dev", but I can understand how that could be a poor experience for someone. Maybe we just need clearer documentation around this?
I don't feel that strongly about name, but I slightly prefer the I'm fine to add more docs or choose a different name, but I do want to get something in ASAP that will remove the v0.5.0 references from our CRDs so we don't have multiple variations of v0.5.0 CRDs floating around. |
shaneutt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight preference for a different name like main where down the road we could start branching for releases rather than having to do manual changes like this, but given that this sentiment isn't shared I also don't feel it's worth blocking over.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
youngnick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Now that we've released v0.5.0, we need to bump our version refs throughout to avoid future API changes being included in CRDs labeled "v0.5.0".
Does this PR introduce a user-facing change?: