generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 618
Closed as not planned
Labels
area/conformance-testIssues or PRs related to Conformance tests.Issues or PRs related to Conformance tests.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
What would you like to be added:
Checks if the headers are mirrored in the request sent.
Why this is needed:
While developing conformance tests, we discovered an issue with the ExpectMirroredRequest method (https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/http/mirror.go#L32). This method verifies that a request is mirrored properly. However, it was only checking that the path matched for mirrored requests. It did not have checks in place for the headers.
This is problematic because headers can also be modified or added to requests. To have fully conformant request mirroring, the test method needs to account for headers as well as the path.
More context: #2101 (comment)
/kind feature
/area conformance
robscott
Metadata
Metadata
Assignees
Labels
area/conformance-testIssues or PRs related to Conformance tests.Issues or PRs related to Conformance tests.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.