Consistent status reasons

[howardjohn]

GatewayConditionReady is extended. It has a set of reasons:
// * "ListenersNotValid"
// * "ListenersNotReady"
// * "AddressNotAssigned"

ListenerConditionProgrammed is core, but it only has a few reasons:
// * "Invalid"
// * "Pending"

Given these represent almost the same thing, it seems like these should be the same set, or GatewayConditionReady should be a superset

similar concern on Listener status

[robscott]

Good catch, agree that these should all be present for both conditions.

/help

[howardjohn]

Also I think the spec is pretty clear but while I am here to double check... if I cannot say "traffic is ready to flow immediately" I should just not set Ready at all, right? And only use Programmed?

[arkodg]

Also I think the spec is pretty clear but while I am here to double check... if I cannot say "traffic is ready to flow immediately" I should just not set Ready at all, right? And only use Programmed?

+1 to this, helps users understand the difference between CP programmed and DP ready
cc @dprotaso

[howardjohn]

So my interpretation means:

• Accepted: I got far enough to start sending some data to the data plane
• Programmed: I got far enough to start send all the data to the data plane
• Ready (optional): I sent all the data to the data plane and it fully processed it and is ready to go

[robscott]

Also I think the spec is pretty clear but while I am here to double check... if I cannot say "traffic is ready to flow immediately" I should just not set Ready at all, right? And only use Programmed?

Yep, the requirements for setting ready have become pretty strict:

gateway-api/apis/v1beta1/gateway_types.go

Lines 609 to 611 in 1c4ae61

	// Ready is an optional Condition that has Extended support. When it's set,
	// the condition indicates whether the Gateway has been completely configured
	// and traffic is ready to flow through the data plane immediately.

If there were some kind of delay after which you could guarantee readiness that may also be a good reason to set "Ready", but not sure if that's a good idea.

[robscott]

@gauravkghildiyal has volunteered to work on this one

[robscott]

/remove-help

[arkodg]

would be good to add conformance tests to make sure if Route reports status as Ready, all requests through it must succeed

[robscott]

@arkodg completely agree, mind creating an issue to track that?

[howardjohn]

One other issue I noticed is I would assume Ready > Programmed > Accepted. However, consider this status:"

  - lastTransitionTime: fake
    message: 'failed to assign
      to all requested addresses: hostname "istio-ingressgateway.not-default.svc.domain.suffix"
      not found'
    reason: NoResources
    status: "False"
    type: Accepted
  - lastTransitionTime: fake
    message: Resource programmed
    reason: Programmed
    status: "True"
    type: Programmed

I want to make Programmed=False because its not Accepted, but the only valid reasons for Programmed=False is Invalid or Pending, and Pending says "controller has not reconciled yet"; neither of these seem quite true