Skip to content

webhook/conformance: Handle incompatible HTTP Filters on a rule #1521

@sunjayBhatia

Description

@sunjayBhatia

Re: The last two bullets in this section of GEP-1364: https://gateway-api.sigs.k8s.io/geps/gep-1364/#accepted

* A HTTPRoute with one rule that specifies a HTTPRequestRedirect filter and a HTTPURLRewrite filter. Accepted must be false,
  because there's only one rule, and this configuration for the rule is invalid (see [reference](https://gateway
  api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRequestRedirectFilter)) The error condition in this
  case is undefined currently - we should define it, thanks @sunjayBhatia.

* A HTTPRoute with two rules, one valid and one which specifies a HTTPRequestRedirect filter _and a HTTPURLRewrite filter.
  Accepted is true, because the valid rule can produce some config in the data plane. We'll need to raise the more specific error
  condition for an incompatible filter combination as well to make the partial validity clear.

For incompatible filters in an HTTPRoute, seems like we can do somethings similar to this change that validates HTTP header filters: #1497

We could do this instead of/in addition to the status changes described in the GEP

Metadata

Metadata

Assignees

Labels

priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions