generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 617
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Milestone
Description
What would you like to be added:
Something that allows us to:
- Run tests using the latest webhook image that has been built (latest commit, not latest release)
- Still pass
hack/verify-codegen.sh - Have a simple release process that allows us to at least temporarily set a fixed image version in our webhook deployment for our generated YAML attached to the release + the config/webhook YAML found at the release tag.
Why this is needed:
At one point we added the following to the script to ensure that our deployed YAML would use the latest image while our manifests on the main branch would not:
# Temporary workaround for release
sed -i 's/v0.5.0/latest/g' config/webhook/admission_webhook.yaml
This had the unfortunate affect of making a change that would cause our hack/verify-codegen.sh script to fail. #1348 (comment) resolved that issue, but it all feels like a bit of a hack. We need a more resilient solution here.
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.