"good" state for ListenerStatus feels logically inverted, difficult to understand

[mikemorris]

What would you like to be added:

• Add ListenerConditionType Attached (or possibly Accepted for parity with other objects, ref discrepancies between Accepted, Ready, and Detached condition types and reasons #1111 ), deprecate Detached

Why this is needed:

From a quick glance, seeing a ListenerStatus with Detached and Conflicted conditions on a Gateway can be a red herring leading an operator to initially think a Listener is not working properly - this may be particularly confusing for new users unfamiliar with checking for the "negative" case of Detached: {status: false, reason: Attached}, Conflicted: {status: false, reason: NoConflicts} meaning that the Listener is actually in a "good" state.

This potential confusion about whether a Listener is working as expected is slightly exacerbated by the ListenerStatus field being a child of GatewayStatus rather than being a status field directly on Listener.

I initially considered if Conflicted should be changed too, but I think just this change alone could make the status conditions for a Listener feel a bit more intuitve.

[youngnick]

Agreed, we should have the same Attached condition type across every place we use conditions, and have it mean the same thing.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[youngnick]

/remove-lifecycle stale

[mikemorris]

GEP-1364 has been approved, deprecating ListenerConditionDetached and proposing that ListenerConditionAccepted be used instead.

This GEP also addresses the confusion with the Conflicted status by setting an expectation that positive polarity error status conditions should only be present when the error state exists.