Skip to content

Conversation

danehans
Copy link
Contributor

This PR pins the quickstart to the v1.0.0 release. This is needed to provide stability to the quickstart guide until #422 is fixed. Note that #1494 tracks the need to update the release script to manage versioning.

What type of PR is this?
Add one of the following kinds:
/kind bug
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7e2cc1c
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c9ff371d39ca00082d31eb
😎 Deploy Preview https://deploy-preview-1604--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2025
@danehans
Copy link
Contributor Author

If others prefer, I can update the dependency section to set $ export VERSION=v1.0.0, so it's easier to maintain the GIE version in the doc. @kfswain @nirrozenbaum @robscott WDYT?

@nirrozenbaum
Copy link
Contributor

If others prefer, I can update the dependency section to set $ export VERSION=v1.0.0, so it's easier to maintain the GIE version in the doc. @kfswain @nirrozenbaum @robscott WDYT?

mmm. I think we should be able to test main in a very easy and straight forward way.
we also want to find issues in main asap and fix them.
considering the fact that #422 is a long term task and doesn't look like it's going to be solved very soon, I would keep the quickstart with main.
I understand the need for stability, but if I need to select one option considering the tradeoff, I'd go with main rather than pin version to v1.

having said the above, not going to insist on it if others think otherwise :)

@danehans
Copy link
Contributor Author

I think we should be able to test main in a very easy and straight forward way.

IMHO main is tested with e2e tests. If we need to test different gateway implementations, then let's update the e2e's to include currently supported gateways. As for manualy testing main, e.g. quickstart doc, we should keep separate steps in the /docs dir where other dev docs exist. This can be temporary until we support multi-version docs (#422).

I would keep the quickstart with main.

The current approach has been fragile and the quickstart is meant to be user facing whereas working on main is dev-facing. We need a stable versioned quickstart, especially now that the project is v1.0.0. As an alternative, I'm in favor of scaling back the quickstart to only installing GIE CRDs and the EPP Helm chart then linking to the conformance page for install/uninstall gateway-specific steps.

@danehans
Copy link
Contributor Author

Note: If the quickstart is versioned, the following steps should be completed:

  1. Merge this PR.
  2. Bump the quickstart v1.0.0 refs to v1.0.1 (similar to this PR). Preferably, this is done by updating the release script instead of manually.
  3. Cut a v1.0.1 patch release.

@kfswain
Copy link
Collaborator

kfswain commented Sep 17, 2025

Sorry, I'm not up to date. Why would we need to cut a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants