Skip to content

Conversation

@DirectXMan12
Copy link
Contributor

Reverts #108. Due to the way kubebuilder has its deps pinned, the update broke new kubebuilder installations. We'll need to document the update process before we do the update.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2018
@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@DirectXMan12 DirectXMan12 merged commit d6eb543 into master Aug 14, 2018
@DirectXMan12 DirectXMan12 deleted the revert-108-update-k8s-1.11 branch August 14, 2018 19:10
@hasbro17 hasbro17 mentioned this pull request Nov 13, 2018
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
…8-update-k8s-1.11

Revert "Updating to k8s 1.11."
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Clarify notion of 'version' in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants