🐛 Fix race conditions ScaleDownOldMS OnDelete #12830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machinedeployment
k8s-ci-robot
added
the
size/XXL
|
/test pull-cluster-api-e2e-main |
66 tasks
fabriziopandini
force-pushed
the
fix-scaleDownOldMS-OnDelete
branch
from
2fbf142 to
ba25c93
Compare
fabriziopandini
force-pushed
the
fix-scaleDownOldMS-OnDelete
branch
from
ba25c93 to
3670866
Compare
sbueringer
reviewed
Oct 8, 2025
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete_test.go
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete_test.go
Outdated
Show resolved
Hide resolved
fabriziopandini
added
the
tide/merge-method-squash
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0325be143c34ded32835884f058695e2724fff00
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Nothing stands out to me as an issue. /lgtm |
|
Thanks for the timely review folks! /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is similar in concept to #12812, but it focuses on OnDelete strategy
Which issue(s) this PR fixes:
Part of #12291
/area machinedeployment