✨ Add types and hook for GenerateUpgradePlan #12823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterclass
k8s-ci-robot
added
the
size/L
sivchari
force-pushed
the
add-generate-upgrade-plan-types-and-hooks
branch
from
637a583 to
06c7d6f
Compare
sbueringer
reviewed
Oct 7, 2025
sbueringer
reviewed
Oct 7, 2025
|
I'd work on your reviews next week 👍 |
26 tasks
Signed-off-by: sivchari <[email protected]>
|
@sbueringer @fabriziopandini |
sivchari
force-pushed
the
add-generate-upgrade-plan-types-and-hooks
branch
2 times, most recently
from
1d8cf92 to
45ffaf7
Compare
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
add-generate-upgrade-plan-types-and-hooks
branch
from
45ffaf7 to
e4db88d
Compare
sbueringer
reviewed
Oct 23, 2025
|
@sivchari Thank you! Last 1-2 nits, otherwise ready for merge |
|
@sbueringer |
sivchari
force-pushed
the
add-generate-upgrade-plan-types-and-hooks
branch
from
db2413a to
e17cd6c
Compare
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
add-generate-upgrade-plan-types-and-hooks
branch
from
e17cd6c to
54a0541
Compare
sbueringer
added
the
tide/merge-method-squash
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7f609a9d1416353457b783815855aa52c321bf8f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sivchari thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Part of #12720
/area clusterclass