🌱 Simplify KCP matchesKubeadmConfig #12813
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
sbueringer
added
the
area/provider/control-plane-kubeadm
|
/assign @fabriziopandini |
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-filter-refactoring
branch
from
c069292 to
a7d9e68
Compare
|
/test pull-cluster-api-e2e-main |
| match, diff, err := matchClusterConfiguration(currentKubeadmConfig, kcp) | ||
| // takes the KubeadmConfigSpec from KCP and applies the transformations required | ||
| // to allow a comparison with the KubeadmConfig referenced from the machine. | ||
| desiredKubeadmConfig := getAdjustedKcpConfig(kcp, currentKubeadmConfig) |
There was a problem hiding this comment.
What about moving getAdjustedKcpConfig into PrepareKubeadmConfigsForDiff, so we have everything in one func?
There was a problem hiding this comment.
I would keep it here for now.
We don't need it in the upcoming case where we are going to use PrepareKubeadmConfigsForDiff (right in front of CanUpdateMachine) and I'm going to delete getAdjustedKcpConfig entirely as it will be part of ComputeDesiredKubeadmConfig in the next PR
|
/test pull-cluster-api-apidiff-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9919d94e859412323f7d856b0ab24d21257548e4
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #12291