🌱 Refactor MachineTemplateUpToDate #12811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machinedeployment
66 tasks
|
/test pull-cluster-api-e2e-blocking-main |
|
/test pull-cluster-api-e2e-main |
sbueringer
reviewed
Oct 1, 2025
k8s-ci-robot
added
size/XL
fabriziopandini
force-pushed
the
refactor-MachineTemplateUpToDate
branch
from
e5b067b to
3c535ac
Compare
fabriziopandini
added
the
tide/merge-method-squash
|
/test pull-cluster-api-e2e-main |
sbueringer
reviewed
Oct 1, 2025
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 2576dbd5c2e9ae9f11ad8c03557a0b39f1798bf2
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactor MachineTemplateUpToDate to surface info that will be require when we are going to introduce the "canUpgrade in-place" check.
On top of this changes, also the FindNewMachineSet / FindOldMachineSets func have been refactored to allow an easier consumption of the output of MachineTemplateUpToDate, as well as the integration in the same set of NotUpToDateResults of the output of the decision about rolloutAfter.
(we also agreed to proceed with small incremental changes given the complexity of this part of the codebase)
Which issue(s) this PR fixes :
Part of #12291
/area machinedeployment