Skip to content

🌱 Update examples & code snippets in Cluster API book to v1beta2 for ClusterClass #12491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

🌱 Update examples & code snippets in Cluster API book to v1beta2 for ClusterClass #12491

merged 4 commits into from
Aug 5, 2025

Conversation

@sivchari
Copy link
Member

What this PR does / why we need it:

Part of #12448

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2025
fabriziopandini
fabriziopandini reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
Could you kindly check the list of ClusterClass fields in https://main.cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-class/change-clusterclass#effects-on-the-clusters (some of the fields name have been changed)

@sbueringer
Copy link
Member

There are also some more changes coming in via: #12489, sorry.
(please check the diff in clusterclass_types.go)

@fabriziopandini fabriziopandini added the area/documentation Issues or PRs related to documentation label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 17, 2025
sivchari added 2 commits July 31, 2025 17:32
@sivchari
update doc for ClusterClass
eb454cb 
Signed-off-by: sivchari <[email protected]>
@sivchari
update spec
9c9d075 
Signed-off-by: sivchari <[email protected]>
@sivchari sivchari force-pushed the update-book-clusterclass branch from 0acb143 to 9c9d075 Compare July 31, 2025 08:49
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2025
@sivchari
fix link
9931b30 
Signed-off-by: sivchari <[email protected]>
sbueringer
sbueringer reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! two minor findings

@sivchari
address review comment
72b2666 
Signed-off-by: sivchari <[email protected]>
@sivchari
Copy link
Member Author

sivchari commented Aug 5, 2025

@sbueringer
Addressed your review comments. Please review it again 🙏

@sivchari sivchari requested a review from sbueringer August 5, 2025 06:42
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 5, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 77d4bdb28f13bf15ee7305432024e98b4f53c222

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2edc795 into kubernetes-sigs:main Aug 5, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Aug 5, 2025
@sbueringer sbueringer mentioned this pull request Aug 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

4 participants

@sivchari @sbueringer @k8s-ci-robot @fabriziopandini