-
Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ conditions: add V1Beta1 suffix and remove V1Beta2 suffix from condition types and reasons in v1beta2 packages #12091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ conditions: add V1Beta1 suffix and remove V1Beta2 suffix from condition types and reasons in v1beta2 packages #12091
Conversation
|
/test help |
|
@chrischdi: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-main |
|
/assign @fabriziopandini |
fabriziopandini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just a few nits!
|
/test pull-cluster-api-e2e-main |
1 similar comment
|
/test pull-cluster-api-e2e-main |
61574e0 to
c70b4dc
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2cffb00574974969e99190a4dea0150799e965cb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c70b4dc to
3caafa5
Compare
|
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 323769a04f119471dcb93583a78dc8f2019c5edd
|
|
/lgtm In general. Will open a follow-up PR for some nits |
What this PR does / why we need it:
This PR changes the following in types of v1beta2 packages:
V1Beta1suffix for v1beta1 condition typesV1Beta1suffix for v1beta1 condition reasonsV1Beta2suffix from v1beta2 condition typesV1Beta2suffix from v1beta2 condition reasonsWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Part of:
/area api