Skip to content

✨ Implement v1beta2 contract in Machine controller #12038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

✨ Implement v1beta2 contract in Machine controller #12038

merged 1 commit into from
Mar 27, 2025

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Mar 27, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11947

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 27, 2025
@sbueringer sbueringer force-pushed the pr-machine-controller-contract branch from fba336f to 78365ff Compare March 27, 2025 14:42
@sbueringer sbueringer added the area/machine Issues or PRs related to machine lifecycle management label Mar 27, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Mar 27, 2025
@sbueringer sbueringer changed the title [WIP] ✨ Implement v1beta2 contract in Machine controller ✨ Implement v1beta2 contract in Machine controller Mar 27, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025
@sbueringer sbueringer force-pushed the pr-machine-controller-contract branch from 78365ff to cb09cd4 Compare March 27, 2025 15:12
@sbueringer
Copy link
Member Author

sbueringer commented Mar 27, 2025

/test pull-cluster-api-e2e-main

@sbueringer sbueringer mentioned this pull request Mar 27, 2025
Closed
84 tasks
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 27, 2025

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main cb09cd4 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer sbueringer mentioned this pull request Mar 27, 2025
Merged
@sbueringer sbueringer force-pushed the pr-machine-controller-contract branch from cb09cd4 to 25c5922 Compare March 27, 2025 15:40
@sbueringer
Copy link
Member Author

sbueringer commented Mar 27, 2025

/test pull-cluster-api-e2e-main

1 similar comment
@sbueringer
Copy link
Member Author

sbueringer commented Mar 27, 2025

/test pull-cluster-api-e2e-main

@fabriziopandini
Copy link
Member

fabriziopandini commented Mar 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 27, 2025

LGTM label has been added.

Git tree hash: 4cae593c7e103ae1955fa7b389023069dbcc1b8a

@chrischdi
Copy link
Member

chrischdi commented Mar 27, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit c53db05 into kubernetes-sigs:main Mar 27, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Mar 27, 2025
@sbueringer sbueringer deleted the pr-machine-controller-contract branch March 27, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

4 participants

@sbueringer @k8s-ci-robot @fabriziopandini @chrischdi