WIP: Preload cert-manager images for e2e tests #5945
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
/test ? |
|
@nojnhuh: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5945 +/- ##
=======================================
Coverage 44.54% 44.54%
=======================================
Files 279 279
Lines 25140 25140
=======================================
Hits 11199 11199
Misses 13128 13128
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nojnhuh
force-pushed
the
preload-cert-manager-e2e
branch
from
ab7a0ff to
404e1d1
Compare
k8s-ci-robot
added
size/M
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
k8s-ci-robot
added
size/L
|
/retitle WIP: Preload cert-manager images for e2e tests |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
Based on this run we can rule out Copilot's theory that the Its other theory was that kube-apiserver's webhook configuration informer is somehow running extremely far behind and not noticing that the |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
One reproducing run with some extra debug artifacts: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5945/pull-cluster-api-provider-azure-e2e-aks/1982288460500701184 |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
4 similar comments
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
@nojnhuh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What type of PR is this?
/kind flake
What this PR does / why we need it:
After some back and forth with Copilot about #5690, it found that CAPI is preloading cert-manager images onto the management cluster for its e2e tests. Saving the image pull time when cert-manager is installed during
clusterctl initmight be enough to consistently avoid a potential timing issue causing the webhook cert validation to fail in CAPZ's tests.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: