Skip to content

🌱 Add kind: Metadata to metadata manifests #5637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

🌱 Add kind: Metadata to metadata manifests #5637

merged 1 commit into from
Aug 29, 2025

Conversation

@damdo
Copy link
Member

@damdo damdo commented Aug 29, 2025

What type of PR is this?
/kind support

What this PR does / why we need it:
Requirement introduced by kubernetes-sigs/cluster-api#12242 and required by CAPI v1.11 (and thus its clusterctl)

Release note:

add Metadata kind to metadata

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2025
@damdo
Copy link
Member Author

damdo commented Aug 29, 2025

/assign @nrb @richardcase @dlipovetsky @AndiDog @Ankitasw

@damdo
Copy link
Member Author

damdo commented Aug 29, 2025

/cherry-pick release-2.9

@k8s-infra-cherrypick-robot
Copy link

@damdo: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo damdo changed the title Add kind: Metadata to metadata manifests 🌱 Add kind: Metadata to metadata manifests Aug 29, 2025
@JoelSpeed
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b5fa8bba4c3d0584fe7a224870556704c385446

nrb
nrb approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit cfdcb14 into kubernetes-sigs:main Aug 29, 2025
24 of 25 checks passed
@k8s-infra-cherrypick-robot
Copy link

@damdo: new pull request created: #5639

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrb nrb nrb approved these changes

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@JoelSpeed JoelSpeed

@Ankitasw Ankitasw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@damdo @k8s-infra-cherrypick-robot @JoelSpeed @k8s-ci-robot @nrb @richardcase @AndiDog @dlipovetsky @Ankitasw