🐛 Set conditions to true when reconciliation is successful

[fiunchinho]

What type of PR is this?

/kind bug

What this PR does / why we need it:

We only set these conditions to false when there is a problem in the reconciliation. But if the reconciliation eventually succeeds, we never set them back to true.

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Set conditions to true when reconciliation is successful

[fiunchinho]

/test ?

[k8s-ci-robot]

@fiunchinho: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[damdo]

Looks like a reasonable fix
@fiunchinho Do you have visual evidence these have moved back to True?

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ef889877102343ea6fd85f24c49be1c84753154c

[fiunchinho]

Looks like a reasonable fix @fiunchinho Do you have visual evidence these have moved back to True?

/lgtm

Yes, I tested this change in our management cluster.

[damdo]

Cool thanks @fiunchinho

/assign @nrb

[nrb]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndiDog]

/lgtm