Skip to content

🐛 fix: missing controller permissions #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

🐛 fix: missing controller permissions #5537

merged 2 commits into from
Jun 10, 2025

Conversation

@richardcase
Copy link
Member

@richardcase richardcase commented Jun 9, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This adds some missing permissions for the controller as found from the e2e tests. Also it adds retry when waiting for the bastion to be ready.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5535

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

action required
Add missing permissions for controller. Its recommended that you update your CloudFormation stack.

@richardcase
fix: missing controller permissions
8a0adec 
This adds some missing permissions for the controller as found
from the e2e tests.

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from damdo and nrb June 9, 2025 10:52
@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2025
@richardcase
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

2 similar comments
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase richardcase force-pushed the 5535_missing_permissions branch from 20d5eca to 0a9bd04 Compare June 9, 2025 15:55
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase richardcase force-pushed the 5535_missing_permissions branch from 0a9bd04 to cf9faa5 Compare June 10, 2025 07:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2025
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase
fix: add eventually for bastion ready
f5c0e0f 
Adds an eventually check around the bastion status check.

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase force-pushed the 5535_missing_permissions branch from cf9faa5 to f5c0e0f Compare June 10, 2025 09:01
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member Author

/cherrypick release-2.8

@k8s-infra-cherrypick-robot
Copy link

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fiunchinho
fiunchinho reviewed Jun 10, 2025
View reviewed changes
test/e2e/suites/unmanaged/helpers_test.go
Comment on lines -421 to -425
Expect(actual).To(Not(BeNil()))
Expect(actual.Type).To(Equal(c.conditionType))
Expect(actual.Status).To(Equal(c.status))
Expect(actual.Severity).To(Equal(c.severity))
Expect(actual.Reason).To(Equal(c.reason))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: Why these need to be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the tests would only call this once and the assertions would fail the test. However, now we are using an Eventually we need to check the conditions in a loop and so we just return true or false instead of failing an assertion.

fiunchinho
fiunchinho approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5a173024f346fc77f0e59721e14db6cc3d8b016

@nrb
Copy link
Contributor

nrb commented Jun 10, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 517ae6c into kubernetes-sigs:main Jun 10, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v2.8 milestone Jun 10, 2025
@k8s-infra-cherrypick-robot
Copy link

@richardcase: new pull request created: #5539

In response to this:

/cherrypick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@nrb nrb Awaiting requested review from nrb

1 more reviewer

@fiunchinho fiunchinho fiunchinho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fiunchinho fiunchinho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v2.8

Development

Successfully merging this pull request may close these issues.

Missing permission errors from e2e logs

5 participants

@richardcase @k8s-ci-robot @k8s-infra-cherrypick-robot @nrb @fiunchinho