Skip to content

✨ ROSA: Add additionalSecurityGroups field to ROSAMachinePool #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

✨ ROSA: Add additionalSecurityGroups field to ROSAMachinePool #4848

merged 1 commit into from
Mar 5, 2024

Conversation

@muraee
Copy link
Contributor

@muraee muraee commented Mar 5, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add additionalSecurityGroups field to ROSAMachinePool

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@muraee muraee changed the title ✨ ROSA: Add additionalSecurityGroups field to ROSAmachinePool ✨ ROSA: Add additionalSecurityGroups field to ROSAMachinePool Mar 5, 2024
@muraee muraee force-pushed the rosa-additional-sgs branch from 63dac09 to 7747fb2 Compare March 5, 2024 15:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@muraee muraee force-pushed the rosa-additional-sgs branch from a423055 to 7747fb2 Compare March 5, 2024 16:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2024
@muraee muraee force-pushed the rosa-additional-sgs branch from 7747fb2 to d2ac6e8 Compare March 5, 2024 17:04
@muraee muraee force-pushed the rosa-additional-sgs branch from d2ac6e8 to 4df5b91 Compare March 5, 2024 17:06
vincepri
vincepri approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9b6fe34 into kubernetes-sigs:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@luthermonson luthermonson Awaiting requested review from luthermonson

1 more reviewer

@vincepri vincepri vincepri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vincepri vincepri

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muraee @k8s-ci-robot @vincepri