✨ ROSA: Reconcile ROSAMachinePool.spec.ProviderIDList #4831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
needs-priority
size/M
muraee
changed the title
muraee
force-pushed
the
machinepool-providerid-list
branch
from
0139038 to
c35d98b
Compare
k8s-ci-robot
added
release-note
muraee
force-pushed
the
machinepool-providerid-list
branch
2 times, most recently
from
b5277bc to
a0912f1
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/L
muraee
force-pushed
the
machinepool-providerid-list
branch
from
a0912f1 to
5c2f126
Compare
k8s-ci-robot
added
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
muraee
force-pushed
the
machinepool-providerid-list
branch
2 times, most recently
from
bbad5e3 to
fe5bad6
Compare
vincepri
reviewed
Mar 4, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
muraee
force-pushed
the
machinepool-providerid-list
branch
from
af9cd42 to
bdc0f2e
Compare
k8s-ci-robot
removed
the
lgtm
muraee
force-pushed
the
machinepool-providerid-list
branch
from
bdc0f2e to
da2f805
Compare
- sync replicase to CAPI MachinePool when autoscaling is enabled - fixed ROSAMachinePool not reporting ready when autoscaling enabled
muraee
force-pushed
the
machinepool-providerid-list
branch
from
da2f805 to
88c31a9
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
spec.ProviderIDListis required to fulfill CAPI MachniePool contract so the CAPI controller can match then to Nodes and report readiness.depends on #4804
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: