Skip to content

Fix session surviving cluster purge and recreate through cache #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix session surviving cluster purge and recreate through cache #4162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cloud/scope/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ func sessionForClusterWithRegion(k8sClient client.Client, clusterScoper cloud.Cl
_, err := providers[0].Retrieve()
if err != nil {
conditions.MarkUnknown(clusterScoper.InfraCluster(), infrav1.PrincipalCredentialRetrievedCondition, infrav1.CredentialProviderBuildFailedReason, err.Error())

// delete the existing session from cache. Otherwise, we give back a defective session on next method invocation with same cluster scope
sessionCache.Delete(getSessionName(region, clusterScoper))

return nil, nil, errors.Wrap(err, "Failed to retrieve identity credentials")
}
awsConfig = awsConfig.WithCredentials(credentials.NewChainCredentials(awsProviders))
Expand Down